Skip to content

Fix horizontal overflow on small screens in theme details section#7953

Open
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:fix/remove-margin-theme-preview
Open

Fix horizontal overflow on small screens in theme details section#7953
im3dabasia wants to merge 1 commit intoWordPress:trunkfrom
im3dabasia:fix/remove-margin-theme-preview

Conversation

@im3dabasia
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/62647

Description

A margin of 30px was added to the right of the theme screenshots on larger screens (above 650px) to create a gap between the screenshots and the description. However, this margin was not being removed on smaller screens (below 650px), causing an overflow on the x-axis and resulting in a horizontal scroll.

I removed the margin for smaller screens, as it is unnecessary when the screenshots and description are stacked. This change resolves the issue.

Steps to reproduce:

  1. WP-Admin >. Appearance > Themes
  2. Hover over any theme
  3. Click on the 'Theme Details'
  4. Notice that there is a margin-right added in the .theme-screenshots class, which is causing an overflow on the x-axis.

Screencast:

Before the patch:

Screen.Recording.2024-12-05.at.11.05.44.AM.mov

After the patch:

Screen.Recording.2024-12-05.at.11.07.29.AM.mov

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props im3dabasia1.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant