Twenty Ten: Fix editor styles affecting block editor UI elements#8104
Twenty Ten: Fix editor styles affecting block editor UI elements#8104Sukhendu2002 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| max-width: 640px; | ||
| } | ||
| * { | ||
| html .mceContentBody, |
There was a problem hiding this comment.
@Sukhendu2002 Thanks for the PR. Shouldn't we update this file as well /editor-style-rtl.css?
There was a problem hiding this comment.
@Mai-Saad, thanks for the review. yes, I will update the pr accordingly.
There was a problem hiding this comment.
It looks like other themes only use body: would that work here?
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentytwelve/editor-style.css#L12
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyfourteen/css/editor-style.css#L34
There was a problem hiding this comment.
@carolinan Thanks for the suggestion! The body selector is working fine in this case, so I have updated the PR accordingly.
There was a problem hiding this comment.
I’ve fixed the + icon issue and updated the PR.
|
@Sukhendu2002 Thanks for the PR. I applied the changes mentioned on the PR manually and can see the + is not displayed for added columns. can you please check. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |

Trac ticket: https://core.trac.wordpress.org/ticket/62792
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.