Skip to content

Users: Disallow bulk editing a single user with no roles. #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hug0-Drelon wants to merge 5 commits into from
Closed

Users: Disallow bulk editing a single user with no roles. #8829

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c2979e
Die early when current user set no roles to itself.
Hug0-Drelon May 22, 2025
17b5b23
Merge branch 'trunk' into fix-63068
audrasjb Mar 12, 2026
b75bd71
Merge branch 'trunk' into fix-63068
audrasjb Mar 12, 2026
2f6aaa3
Merge branch 'trunk' into fix-63068
audrasjb Mar 12, 2026
41379ef
Merge branch 'trunk' into fix-63068
audrasjb Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/wp-admin/users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,18 @@
wp_die( __( 'Sorry, you are not allowed to edit this user.' ), 403 );
}

// The new role of the current user must also have the promote_users cap or be a multisite super admin.
if ( $id === $current_user->ID
&& ! $wp_roles->role_objects[ $role ]->has_cap( 'promote_users' )
&& ! ( is_multisite() && current_user_can( 'manage_network_users' ) )
) {
$update = 'err_admin_role';
// The new role of the current user must also have the promote_users cap, be a multisite super admin and not be empty.
if ( $id === $current_user->ID ) {
if ( '' === $role ) {
wp_die( __( 'Sorry, you cannot remove your own role.' ), 403 );
}

if ( $wp_roles->role_objects[ $role ]->has_cap( 'promote_users' ) || ( is_multisite() && current_user_can( 'manage_network_users' ) ) ) {
continue;
}

$update = 'err_admin_role';
continue;
}

// If the user doesn't already belong to the blog, bail.
Expand Down
Loading