Docs: Correct wp_ext2type() return type from void to null#9679
Docs: Correct wp_ext2type() return type from void to null#9679rollybueno wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the PR! In core, I think we generally use That said, we could perhaps reconsider this, but ideally in a consistent way 🙂 |
|
Thanks. Closing here then, we can think about that sometime in the future. |
Per the PHP manual, if a function omits return, the value null is returned.
wp_ext2type()either returns a string for known extensions or null when no match is found. The doc block is updated to reflect this: string|null.Trac ticket: https://core.trac.wordpress.org/ticket/63166
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.