HTML API: Replace use of PCRE functions with new UTF-8 pipeline. #9798
+82
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
changed the title
This was referenced Sep 10, 2025
dmsnell
force-pushed
the
utf8/html-api-updates
branch
6 times, most recently
from
b1b2685 to
0ffcb16
Compare
dmsnell
force-pushed
the
utf8/html-api-updates
branch
8 times, most recently
from
a8ddba0 to
72fb7da
Compare
dmsnell
force-pushed
the
utf8/html-api-updates
branch
5 times, most recently
from
f9a9f8f to
d2b7962
Compare
dmsnell
force-pushed
the
utf8/html-api-updates
branch
2 times, most recently
from
d0ec804 to
1687950
Compare
dmsnell
force-pushed
the
utf8/html-api-updates
branch
3 times, most recently
from
25e7519 to
b7a3e5e
Compare
dmsnell
force-pushed
the
utf8/html-api-updates
branch
14 times, most recently
from
f8623e9 to
eea5d1f
Compare
The only PCRE in the HTML API was used to validate a given attribute name when setting an attribute. This change relies on the new UTF-8 `wp_has_noncharacters()` method, removing the reliance on the PCRE extension and unifying behaviors across PHP runtime environments.
dmsnell
force-pushed
the
utf8/html-api-updates
branch
from
eea5d1f to
7f3fea4
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
that referenced
this pull request
Oct 21, 2025
The HTML API has relied upon a single PCRE to determine whether to allow setting certain attribute names. This was because those names aren’t allowed to contain Unicode noncharacters, but detecting noncharacters without a UTF-8 parser is nontrivial. In this change the direct PCRE has been replaced with a number of `strcpn()` calls and a call to the newer `wp_has_noncharacters()` function. Under the hood, this function will still defer to a PCRE if Unicode support is available, but otherwise will fall back to the UTF-8 pipeline in Core. This change removes the platform variability, making the HTML API more reliable when Unicode support for PCRE is lacking. Developed in #9798 Discussed in https://core.trac.wordpress.org/ticket/63863 See #63863. git-svn-id: https://develop.svn.wordpress.org/trunk@61003 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 21, 2025
The HTML API has relied upon a single PCRE to determine whether to allow setting certain attribute names. This was because those names aren’t allowed to contain Unicode noncharacters, but detecting noncharacters without a UTF-8 parser is nontrivial. In this change the direct PCRE has been replaced with a number of `strcpn()` calls and a call to the newer `wp_has_noncharacters()` function. Under the hood, this function will still defer to a PCRE if Unicode support is available, but otherwise will fall back to the UTF-8 pipeline in Core. This change removes the platform variability, making the HTML API more reliable when Unicode support for PCRE is lacking. Developed in WordPress/wordpress-develop#9798 Discussed in https://core.trac.wordpress.org/ticket/63863 See #63863. Built from https://develop.svn.wordpress.org/trunk@61003 git-svn-id: http://core.svn.wordpress.org/trunk@60339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 21, 2025
The HTML API has relied upon a single PCRE to determine whether to allow setting certain attribute names. This was because those names aren’t allowed to contain Unicode noncharacters, but detecting noncharacters without a UTF-8 parser is nontrivial. In this change the direct PCRE has been replaced with a number of `strcpn()` calls and a call to the newer `wp_has_noncharacters()` function. Under the hood, this function will still defer to a PCRE if Unicode support is available, but otherwise will fall back to the UTF-8 pipeline in Core. This change removes the platform variability, making the HTML API more reliable when Unicode support for PCRE is lacking. Developed in WordPress/wordpress-develop#9798 Discussed in https://core.trac.wordpress.org/ticket/63863 See #63863. Built from https://develop.svn.wordpress.org/trunk@61003 git-svn-id: https://core.svn.wordpress.org/trunk@60339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63863
See:
#9825,#9830,#9498,#9826,#9827, (#9798),#9828,#9829Relies on the new UTF-8 pipeline to eliminate the use of
preg_match()in the HTML API.