[Website] fs-journal: replace recursion with a loop to stop exceeding the call stack #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces recursion with a loop in the filesystem journal code to avoid
the following error when installing Woo on an OPFS site:
```
Uncaught (in promise) RangeError: Maximum call stack size exceeded
at normalizeFilesystemOperations (fs-journal.ts:364:17)
at normalizeFilesystemOperations (fs-journal.ts:473:11)
...
```
\## Implementation
`normalizeFilesystemOperations()` used to call itself in a way that
significantly inflated the callstack when either there was either a
lot of operations to normalize, or the normalized operations referenced
each other recursively.
This PR replaces the recursive call with a while(true) loop which
limits the callstack size and allows the normalization to finish.
\## Testing instructions
Create a new site, save it "to this browser", go to wp-admin, loop up
Woo, click install, confirm it worked.
adamziel
added
[Type] Bug
Removed the test for installing WooCommerce via wp-admin after saving the site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces recursion with a loop in the filesystem journal code to avoid
the following error when installing Woo on an OPFS site:
Implementation
normalizeFilesystemOperations()used to call itself in a way thatsignificantly inflated the callstack when either there was either a
lot of operations to normalize, or the normalized operations referenced
each other recursively.
This PR replaces the recursive call with a while(true) loop which
limits the callstack size and allows the normalization to finish.
Testing instructions
Create a new site, save it "to this browser", go to wp-admin, loop up
Woo, click install, confirm it worked.## Motivation for the change, related issues
cc @draganescu