[PHP] Add few more function names and Refactor test files#3287
Merged
Conversation
mho22
changed the title
bgrgicak
reviewed
Feb 19, 2026
Comment on lines
+105
to
+115
| if (options.withXdebug) { | ||
| const xdebugIniPath = | ||
| '/internal/shared/extensions/xdebug.ini'; | ||
|
|
||
| php.writeFile( | ||
| xdebugIniPath, | ||
| php | ||
| .readFileAsText(xdebugIniPath) | ||
| .replace('debug,develop', 'debug') | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
@mho22 could you add a comment here that explains why we need to remove develop for this test?
Collaborator
|
I left one small comment, but otherwise it looks good. Thanks for working on this @Utsav-Ladani @mho22! |
mho22
force-pushed
the
php-magic-methods-asyncify-errors
branch
from
377c340 to
eb31b46
Compare
mho22
force-pushed
the
php-magic-methods-asyncify-errors
branch
from
0c0a5d0 to
becd721
Compare
Collaborator
Author
|
@brandonpayton II've been having some trouble getting this pull request to pass the file locking and Asyncify tests since the multi-workers merge. Do you have any idea what might be wrong? I only added a couple of Asyncify functions in this pull request. |
Member
|
@mho22 this was due to a mistake on my part. I added a brief check to insist on the presence of a processId during PHP-WASM init but failed to rebuild rebuild PHP-WASM. I'm sorry for the trouble and will push some fixes to this PR. |
brandonpayton
approved these changes
Feb 24, 2026
Collaborator
Author
|
@brandonpayton Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Reproduces issues from pull request : #3037
Related to issue : #2957
Thanks to the great work by @Utsav-Ladani, I was able to figure out the remaining errors.
Implementation details
Testing Instructions (or ideally a Blueprint)
CI