Simplify personal WP app installer#3623
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR simplifies the Personal WP “Install Apps” flow by removing the remote app catalog/custom app paste UI and replacing it with a single “App Launcher” install link backed by an inline data-URL blueprint.
Changes:
- Removed remote app catalog fetching + custom app paste/remove UI in favor of a single App Launcher link
- Added an inline App Launcher blueprint encoded as a data URL
- Added a Playwright assertion that validates the App Launcher link includes an encoded blueprint URL
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/personal-wp/src/components/site-manager/site-info-panel/index.tsx | Replaces apps list/custom apps with a single App Launcher install link backed by an inline blueprint data URL |
| packages/playground/personal-wp/playwright/e2e/ui.spec.ts | Adds an E2E assertion verifying the App Launcher link contains an encoded blueprint URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note: nx target wrappers failed in the local sandbox before running tasks because Nx plugin workers could not start; direct equivalent commands passed.