Rename the project to WordPress Playground #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
pushed a commit
that referenced
this pull request
May 7, 2025
## Motivation for the change, related issues We currently live with the following undefined symbol warnings when linking with Emscripten: ``` #84 1.878 warning: undefined symbol: SharpYuvConvert (referenced by root reference (e.g. compiled C/C++ code)) #84 1.878 warning: undefined symbol: SharpYuvGetConversionMatrix (referenced by root reference (e.g. compiled C/C++ code)) #84 1.878 warning: undefined symbol: SharpYuvInit (referenced by root reference (e.g. compiled C/C++ code)) #84 1.880 warning: undefined symbol: getcontext (referenced by root reference (e.g. compiled C/C++ code)) #84 1.880 warning: undefined symbol: getdtablesize (referenced by root reference (e.g. compiled C/C++ code)) #84 1.880 warning: undefined symbol: makecontext (referenced by root reference (e.g. compiled C/C++ code)) #84 1.880 warning: undefined symbol: swapcontext (referenced by root reference (e.g. compiled C/C++ code)) ``` If any new undefined symbols come up, we would not notice them because we set `ERROR_ON_UNDEFINED_SYMBOLS=0`. Let's change this to error so we do not quietly miss new undefined symbols. ## Implementation details Set ERROR_ON_UNDEFINED_SYMBOLS=1 so the Emscripten linker fails if there are any undefined symbols. We have been living with a number of undefined symbols. Some are undefined because Emscripten does not provide them, and others are undefined because we needed to link to an additional library. This PR addresses both cases. In order to be explicit and intentional about undefined symbols we know and accept, this PR adds a JS library for Emscripten that explicitly lists known undefined symbols and declares stubs for them that fail if called. This way, we document the undefined symbols we know about and avoid complaints from Emscripten. ## Testing Instructions (or ideally a Blueprint) - CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.