Plugin Directory: Scope the plugin card pointer cursor to the cards, not the container#665
Plugin Directory: Scope the plugin card pointer cursor to the cards, not the container#665derpaschi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the cursor styling for plugin cards so the pointer cursor is applied more narrowly within the cards grid layout.
Changes:
- Narrowed
cursor: pointerstyling from the entire.plugin-cardscontainer to list items within.is-style-cards-grid.
Files not reviewed (2)
- wordpress.org/public_html/wp-content/themes/pub/wporg-plugins-2024/css/style-rtl.css: Language not supported
- wordpress.org/public_html/wp-content/themes/pub/wporg-plugins-2024/css/style.css: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .plugin-cards .is-style-cards-grid li { | ||
| cursor: pointer; | ||
| } |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
@derpaschi Let's remove that file.
It looks like it's an unintended artifact from the sass options, probably worth a follow-up PR.
What
The plugin cards grid applied
cursor: pointerto the entire.plugin-cardscontainer. As a result the pointer cursor appeared over the grid gaps and padding — areas that aren't clickable — and not just over the cards themselves.This change scopes the rule to
.plugin-cards .is-style-cards-grid li, which lines it up with the existing:hoverand:focus-withinselectors that already target the individual cards.Why
The pointer cursor is a clickability affordance. Showing it over the non-interactive container space is a little misleading, and it was inconsistent with the hover/focus styling that was already scoped to the cards. Tightening the selector keeps the cursor behaviour consistent with the rest of the card interactions.
Testing
css/style.cssandcss/style-rtl.cssare regenerated from the SCSS source.Notes
This is a focused, presentational-only change with no markup or behaviour changes. Feedback very welcome — happy to adjust the selector if there's a preferred convention for this theme.