Skip to content

Modernize lib#11

Merged
nikosd23 merged 6 commits intomasterfrom
modernizeLib
Feb 18, 2026
Merged

Modernize lib#11
nikosd23 merged 6 commits intomasterfrom
modernizeLib

Conversation

@nikosd23
Copy link
Collaborator

package.json — updated dependencies, scripts, and added nyc config:

  • log4js ^3.0.4 → ^6.9.1, mocha ^5.2.0 → ^11.3.0, sinon 1.17.7 → ^18.0.0, typescript 2.1.5 → ^4.9.5
  • Updated @types/mocha, @types/node, @types/sinon, @types/source-map-support
  • Removed istanbul, remap-istanbul, @types/log4js
  • Added nyc ^17.1.0
  • Replaced istanbul/remap-istanbul test scripts with nyc equivalents

17 test files — sinon.sandbox.create() → sinon.createSandbox()

5 source files — removed async from abstract method declarations (TS4 no longer allows this combination):

  • src/lib/processors/aggregator/aggregation-strategy.ts
  • src/lib/processors/aggregator/store.ts
  • src/lib/processors/processor.ts
  • src/lib/processors/throttler/pub-sub.ts
  • src/lib/processors/throttler/queue.ts

3 test files — fixed new Promise(r => r()) → new Promise(r => r()) for TS4 strictness

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernizes the project’s tooling and TypeScript compatibility by upgrading key dependencies (Mocha/Sinon/TypeScript/Log4js), switching coverage tooling to nyc, and applying the necessary source/test updates to compile and run under the newer toolchain.

Changes:

  • Upgraded runtime/dev dependencies (notably log4js, mocha, sinon, typescript) and updated the lockfile to npm lockfile v3.
  • Replaced Istanbul/remap-istanbul coverage scripts with nyc and added nyc configuration in package.json.
  • Updated tests for Sinon sandbox API changes and TypeScript 4 strictness; adjusted abstract method declarations to remove unsupported abstract async combinations.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/test/route.test.ts Updates Sinon sandbox creation for newer Sinon versions.
src/test/processors/throttler/memory-queue.test.ts Updates Sinon sandbox creation.
src/test/processors/throttler/memory-pub-sub.test.ts Updates Sinon sandbox creation and Promise resolve typing.
src/test/processors/throttler.test.ts Updates Sinon sandbox creation and Promise typing for TS4.
src/test/processors/resource-throttler.test.ts Updates Sinon sandbox creation and Promise typing for TS4.
src/test/processors/processor.test.ts Updates Sinon sandbox creation.
src/test/processors/mapper.test.ts Updates Sinon sandbox creation.
src/test/processors/logger.test.ts Updates Sinon sandbox creation.
src/test/processors/filter.test.ts Updates Sinon sandbox creation.
src/test/processors/dispatcher.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/timer.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/store.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/memory-timer.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/memory-store.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/max-num-strategy.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator/aggregation-strategy.test.ts Updates Sinon sandbox creation.
src/test/processors/aggregator.test.ts Updates Sinon sandbox creation.
src/lib/processors/throttler/queue.ts Removes abstract async from method declarations for TS4 compatibility.
src/lib/processors/throttler/pub-sub.ts Removes abstract async from method declarations for TS4 compatibility.
src/lib/processors/processor.ts Removes abstract async from method declarations for TS4 compatibility.
src/lib/processors/aggregator/store.ts Removes abstract async from method declarations for TS4 compatibility.
src/lib/processors/aggregator/aggregation-strategy.ts Removes abstract async from method declarations for TS4 compatibility.
package.json Updates deps/scripts and adds nyc configuration.
package-lock.json Updates dependency graph and lockfile version to v3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nikosd23 nikosd23 merged commit 700e83c into master Feb 18, 2026
@nikosd23 nikosd23 deleted the modernizeLib branch February 18, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments