feat(dependency-injection): add toOverriding and asAllInterfaces binding API improvements#31
Merged
feat(dependency-injection): add toOverriding and asAllInterfaces binding API improvements#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toOverridingvariants —BindingBuildergainstoOverriding(T value),toOverriding(Class<? extends T>), andtoOverriding(Supplier<T>). These replace an existing binding silently rather than throwingBindingAlreadyExistsException, covering the one-off test override use case without needing a fullModules.override()module pair.asAllInterfaces—Contextgains abind(T value)instance overload that returns aBindingBuilder<T>supportingasAllInterfaces()andasAllInterfaces(Predicate<Class<?>>). CallingasAllInterfaces()walks the full interface hierarchy of the bound value's type and registers a binding for each interface, with the default filter excludingjava.*interfaces. This eliminates the unchecked-cast loop pattern that currently appears in spawn'sAbstractTemplatedLauncher(binding a process instance to each of its interfaces).SuppressingBindingBuilderinModulesdelegates the newtoOverridingvariants.collectInterfacesuses recursive reflection to gather all interfaces from the full type hierarchy, not just direct ones.