fix(spin-module-system): resolve named JPMS module names from module-info.class#64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeModelthroughPomWorkspaceWalkerand thePomBased*resources so that named JPMS modules (those with amodule-info.classin their jar) are identified correctly, instead of relying solely on heuristic name derivation andAutomatic-Module-Name. This fixes module resolution for jars like those fromlang.buildthat use proper named modules.getArtifact(ModuleReference)fallback inPomBasedModuleCatalogthat probes the local repository by naming-convention heuristic when a module reference isn't already in the catalog.<dependencyManagement>entries are now inherited transitively from<parent>poms (up to depth 8), and same-groupId sibling dependencies with no explicit<version>now correctly inherit the pom's own version.readDependencyManagementprivate recursive helper to useOptional<Path>instead of a nullable sentinel.