Skip to content

fix(spin-module-system): resolve named JPMS module names from module-info.class#64

Merged
deer merged 1 commit into
mainfrom
maven_workspace
May 12, 2026
Merged

fix(spin-module-system): resolve named JPMS module names from module-info.class#64
deer merged 1 commit into
mainfrom
maven_workspace

Conversation

@deer
Copy link
Copy Markdown
Collaborator

@deer deer commented May 12, 2026

  • Threads CodeModel through PomWorkspaceWalker and the PomBased* resources so that named JPMS modules (those with a module-info.class in their jar) are identified correctly, instead of relying solely on heuristic name derivation and Automatic-Module-Name. This fixes module resolution for jars like those from lang.build that use proper named modules.
  • Adds a getArtifact(ModuleReference) fallback in PomBasedModuleCatalog that probes the local repository by naming-convention heuristic when a module reference isn't already in the catalog.
  • Fixes two POM parsing gaps: <dependencyManagement> entries are now inherited transitively from <parent> poms (up to depth 8), and same-groupId sibling dependencies with no explicit <version> now correctly inherit the pom's own version.
  • Cleans up the readDependencyManagement private recursive helper to use Optional<Path> instead of a nullable sentinel.

@deer deer merged commit 7200fab into main May 12, 2026
1 of 2 checks passed
@deer deer deleted the maven_workspace branch May 12, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant