Skip to content

fix: exports Api and NodeApi for NodeJS#1037

Merged
bhovhannes merged 1 commit intomasterfrom
same-export-for-all
Feb 21, 2022
Merged

fix: exports Api and NodeApi for NodeJS#1037
bhovhannes merged 1 commit intomasterfrom
same-export-for-all

Conversation

@citizensas
Copy link
Copy Markdown
Contributor

Review the exported members for the CommonJS format.
For NodeJS there will be the following exported members;

  • Api - the Api class for NodeJS, previously known as NodeApi,
  • NodeApi - same as above, keeping it for backward compatibility,
  • ResponseHandler - an object containing success and failure callbacks,
  • makeFetchCall - a function that makes the request bound with the ResponseHandler,
  • default - exports Api, NodeApi, and ResponseHandler for backward compatibility purpose only.

Closes #1035.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2022

Codecov Report

Merging #1037 (7ae2147) into master (b0b1107) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1037   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files           1        1           
  Lines         269      269           
  Branches       61       61           
=======================================
  Hits          226      226           
  Misses         29       29           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad3e73...7ae2147. Read the comment docs.

@bhovhannes bhovhannes merged commit a6c367e into master Feb 21, 2022
@citizensas citizensas deleted the same-export-for-all branch February 21, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Workfront.NodeApi is not a constructor

2 participants