Skip to content

Strip soft hyphens and resolve names via SeStringEvaluator#38

Merged
WorkingRobot merged 3 commits intoWorkingRobot:mainfrom
Haselnussbomber:strip-soft-hyphen
Apr 29, 2025
Merged

Strip soft hyphens and resolve names via SeStringEvaluator#38
WorkingRobot merged 3 commits intoWorkingRobot:mainfrom
Haselnussbomber:strip-soft-hyphen

Conversation

@Haselnussbomber
Copy link
Copy Markdown
Contributor

Hey there,
I installed your plugin (yay, crafting!) and saw soft hyphens in German item names (shocking!).
So I present you a PR to fix this situation.

Before:
Before

After:
After

I also stripped them from Status names/descriptions.

Additionally, I've allowed myself to add resolving of ENpcResident names and PlaceNames via the new experimental SeStringEvaluator. Not that it was needed in your case (I don't think any of these use noun placeholders), but I thought why not.

Just as a little hint though, this doesn't fit at all:
Oops, no space
I did not fix that, but I changed the code to format coordinates to use InvariantCulture, because in German (yes, yes) we use , as decimal separator and it should be . for coordinates. And the jobs name first letter should be capitalized in German, so I removed the ToLowerInvariant(). 👀

I hope the changes aren't too annoying and will see ya on Discord (probably).
- Hasel 🙂

@Haselnussbomber
Copy link
Copy Markdown
Contributor Author

Merge conflict solved and I changed it to reuse code by adding a ReadOnlySeString.ExtractCleanText() extension.

@WorkingRobot WorkingRobot merged commit 9148f0e into WorkingRobot:main Apr 29, 2025
@Haselnussbomber Haselnussbomber deleted the strip-soft-hyphen branch April 29, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants