Strip soft hyphens and resolve names via SeStringEvaluator#38
Merged
WorkingRobot merged 3 commits intoWorkingRobot:mainfrom Apr 29, 2025
Haselnussbomber:strip-soft-hyphen
Merged
Strip soft hyphens and resolve names via SeStringEvaluator#38WorkingRobot merged 3 commits intoWorkingRobot:mainfrom Haselnussbomber:strip-soft-hyphen
WorkingRobot merged 3 commits intoWorkingRobot:mainfrom
Haselnussbomber:strip-soft-hyphen
Conversation
Contributor
Author
|
Merge conflict solved and I changed it to reuse code by adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I installed your plugin (yay, crafting!) and saw soft hyphens in German item names (shocking!).
So I present you a PR to fix this situation.
Before:

After:

I also stripped them from Status names/descriptions.
Additionally, I've allowed myself to add resolving of ENpcResident names and PlaceNames via the new experimental SeStringEvaluator. Not that it was needed in your case (I don't think any of these use noun placeholders), but I thought why not.
Just as a little hint though, this doesn't fit at all:

I did not fix that, but I changed the code to format coordinates to use InvariantCulture, because in German (yes, yes) we use
,as decimal separator and it should be.for coordinates. And the jobs name first letter should be capitalized in German, so I removed theToLowerInvariant(). 👀I hope the changes aren't too annoying and will see ya on Discord (probably).
- Hasel 🙂