Skip to content

Update for 7.5 - Update ImRaii usage to new ref struct pattern#63

Open
Edenane wants to merge 3 commits intoWorkingRobot:mainfrom
Edenane:fix/imraii-updates
Open

Update for 7.5 - Update ImRaii usage to new ref struct pattern#63
Edenane wants to merge 3 commits intoWorkingRobot:mainfrom
Edenane:fix/imraii-updates

Conversation

@Edenane
Copy link
Copy Markdown

@Edenane Edenane commented May 4, 2026

This PR updates the plugin to support the recent changes in Dalamud's ImRaii library.
-Removed IEndObject (obsolete/removed).
-Converted custom GroupPanel and ImPlot wrappers to ref structs to prevent boxing and memory allocations.
-Fixed TabItem usage to comply with C# ref-safety rules.
Tested in-game and settings/tabs/panels are functioning correctly.

@Edenane Edenane changed the title Update ImRaii usage to new ref struct pattern Update for 7.5 - Update ImRaii usage to new ref struct pattern May 4, 2026
Comment thread Craftimizer/Craftimizer.csproj Outdated
@@ -2,7 +2,7 @@
<Project Sdk="Dalamud.NET.Sdk/14.0.1">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is not actually incremented in this PR.

Use /15.0.0

Comment thread Craftimizer/Craftimizer.csproj Outdated
Comment on lines +44 to +47
<ItemGroup>
<PackageReference Update="DalamudPackager" Version="15.0.0" />
<PackageReference Update="DotNet.ReproducibleBuilds" Version="2.0.2" />
</ItemGroup>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines, they are handled automatically by the Dalamud.NET.Sdk/15.0.0 definition.

Updated Dalamud sdk to 15.0.0
Removed unneeded package references
@Edenane Edenane requested a review from MidoriKami May 5, 2026 06:58
@andrewljoy
Copy link
Copy Markdown

I can confirm this builds correctly and works in game.

andrewljoy added a commit to andrewljoy/CraftimizerAj that referenced this pull request May 6, 2026
@ifeelkool
Copy link
Copy Markdown

sorry im a bit of a noob but how do i update, like a nice detailed guide on what file to open and update?

@andrewljoy
Copy link
Copy Markdown

sorry im a bit of a noob but how do i update, like a nice detailed guide on what file to open and update?

You can use my fork it has both the waiting PRs merged and i have built a release . you will have to download the zip extract it and import it as a dev plugin in dalmund.

https://github.com/andrewljoy/CraftimizerAj/releases/tag/2.10.0.0

@ifeelkool
Copy link
Copy Markdown

ifeelkool commented May 8, 2026

sorry im a bit of a noob but how do i update, like a nice detailed guide on what file to open and update?

You can use my fork it has both the waiting PRs merged and i have built a release . you will have to download the zip extract it and import it as a dev plugin in dalmund.

https://github.com/andrewljoy/CraftimizerAj/releases/tag/2.10.0.0

wow quick response, can you explain further about importing as dev plugin? not sure what you mean there

edit i figured it out, works like a peach ty so much

@ykkpsdkm6y-ux
Copy link
Copy Markdown

sorry im a bit of a noob but how do i update, like a nice detailed guide on what file to open and update?

You can use my fork it has both the waiting PRs merged and i have built a release . you will have to download the zip extract it and import it as a dev plugin in dalmund.

https://github.com/andrewljoy/CraftimizerAj/releases/tag/2.10.0.0

How come on the launch says out of date I can’t even install it the button grey by change do you know when it will show the plug in as up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants