Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

Update to Dart 2.13#22

Merged
rmconsole5-wk merged 2 commits intomasterfrom
dart_213
Sep 14, 2021
Merged

Update to Dart 2.13#22
rmconsole5-wk merged 2 commits intomasterfrom
dart_213

Conversation

@robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Sep 14, 2021

Motivation

We want to update everything at Workvia to work with Dart 2.13

Changes

Update dependencies and Dockerfile to work under Dart 2.13
Removes last use of dart2_constant

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf
Copy link
Member Author

@rmconsole-wf how you doing? You've been catatonic for hours.
image

@robbecker-wf
Copy link
Member Author

Comment to restart Rosie

@@ -1,4 +1,4 @@
FROM google/dart:2.7.2 as build
FROM google/dart:2.13.4 as build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the google image for open source projects

@robbecker-wf
Copy link
Member Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 6e36fb8 into master Sep 14, 2021
@rmconsole5-wk rmconsole5-wk deleted the dart_213 branch September 14, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants