This repository was archived by the owner on Jul 2, 2024. It is now read-only.
Update lints. Resolved to linter package 0.1.79#5
Merged
georgelesica-wf merged 3 commits intomasterfrom Feb 4, 2019
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
- use double quotes for description and escape double quotes in the content - Stop swallowing exceptions when loading abide.yaml in case there is a syntax error
georgelesica-wf
approved these changes
Feb 4, 2019
Member
Author
|
@Workiva/release-management-pp |
|
RM +1 verified deps are being picked up on tag 1.6.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
abide_upgradeto get the latest lints rules from the linter package. The resolved version of the linter package used was 0.1.79.When upgrading, some of the characters in the descriptions for lint rules caused syntax errors in the resulting YAML file. To defend against this, this PR adds double quotes around the description text and escapes double quotes that happen to be in the description text.
Testing
abide_upgradecommand.pub global activate --source path .abide_upgrade. You should not get any exceptions.