Skip to content

Dart 2.19#16

Merged
rmconsole5-wk merged 1 commit into
masterfrom
batch/fedx/dart_2_19
Oct 27, 2023
Merged

Dart 2.19#16
rmconsole5-wk merged 1 commit into
masterfrom
batch/fedx/dart_2_19

Conversation

@sourcegraph-wk
Copy link
Copy Markdown

Summary

This batch updates CI to use Dart 2.19. In most cases, updating Just Works™,
but here's some things that have changed or may cause problems while updating.

  • The pub and dart2js aliases have been removed. You may need to replace bare pub commands. See the replacements here https://wiki.atl.workiva.net/display/CP/Dart+2.18+FAQ
  • There may be some new lints, or lints that actually function better and now find new issues that need fixing or ignoring.
  • Some lints may have been raised to warnings that now need fixing or ignoring until fixed.
  • Dockerfiles or skynet may try to install things that don't work quite right on newer debian 11 (bullseye)
    • Potential examples are installing python or nodejs into the dart images
  • If you have build.yaml files that "split" the builders into separate targets, you may have to exclude a new builder
  build_resolvers|transitive_digests:
    enabled: false

These PRs are ok to get reviewed and approved.
If it is out of draft and there isn't a `Hold`` label, then it is ok to merge.

For support go to #support-frontend-dx in Slack.

Created by Sourcegraph batch change Workiva/dart_2_19.

@semveraudit-wf
Copy link
Copy Markdown

Public API Changes

No changes to the public API found for commit fc2867e

Showing results for fc2867e

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

@aviary3-wk
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review October 26, 2023 16:19
Copy link
Copy Markdown
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 CI passes on 2.19 @Workiva/release-management-p

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 22238c2 into master Oct 27, 2023
@rmconsole5-wk rmconsole5-wk deleted the batch/fedx/dart_2_19 branch October 27, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants