Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

#6

Need a task that can copy a package's license header to all source files. To start, it should support .dart, .css, .html, and .js files.

Also took care of #23 in an amended commit.

Changes

Source:

  • Adds a copy-license task that reads a license from a file (LICENSE by default) and applies it to all files in a set of directories (['lib/'] by default)

Tests:

  • Adds fixtures for copy-license task testing
  • Adds integration tests for the copy-license task

Areas of Regression

  • n/a

Testing

  • ddev test --integration passes

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
fyi: @jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1

1 similar comment
@dustinlessard-wf
Copy link

+1

@evanweible-wf
Copy link
Contributor Author

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf added the missing copy license documentation to the readme and the generated dev.dart file from the init task.

Rebased onto latest master.

@maxwellpeterson-wf
Copy link
Member

+1

@trentgrover-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title New Task: Copy License CP-843 New Task: Copy License Aug 18, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • ran new integration tests and they passed as expected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 18, 2015
CP-843 New Task: Copy License
@jayudey-wf jayudey-wf merged commit e7be8fe into master Aug 18, 2015
@trentgrover-wf trentgrover-wf deleted the copy-license branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants