Skip to content

CP-851 Dartfmt license header whitespace #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2015
Merged

CP-851 Dartfmt license header whitespace #35

merged 1 commit into from
Aug 19, 2015

Conversation

@evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Aug 18, 2015

Issue

Missed a dartfmt run.

Changes

Ran dartfmt, all of the newly added license headers had whitespace changes.

Areas of Regression

  • n/a

Testing

  • n/a

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link
Contributor

trentgrover-wf commented Aug 18, 2015

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

maxwellpeterson-wf commented Aug 18, 2015

+1

@evanweible-wf
Copy link
Contributor Author

evanweible-wf commented Aug 18, 2015

@jayudey-wf ready for merge, changes only to comments.

@jayudey-wf jayudey-wf changed the title Dartfmt license header whitespace CP-851 Dartfmt license header whitespace Aug 18, 2015
@evanweible-wf evanweible-wf mentioned this pull request Aug 18, 2015
Merged
@jayudey-wf
Copy link
Contributor

jayudey-wf commented Aug 19, 2015

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • white space only change
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 19, 2015
@jayudey-wf
Merge pull request #35 from Workiva/dartfmt
2ef6a56 
CP-851 Dartfmt license header whitespace
@jayudey-wf jayudey-wf merged commit 2ef6a56 into master Aug 19, 2015
@trentgrover-wf trentgrover-wf deleted the dartfmt branch August 19, 2015 21:45
@jayudey-wf jayudey-wf mentioned this pull request Aug 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evanweible-wf @trentgrover-wf @maxwellpeterson-wf @jayudey-wf