Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Dependent on #35.

Issue

The generated license headers for .dart files have trailing whitespace on empty lines, which the dart formatter picks up.
Fixes #36

Changes

Source:

  • Update the copy license task to trim the right side of each line as it generates the license header so that the end result is deemed "clean" by the dart formatter.
  • Also add some license headers that were missed.

Tests:

  • n/a, tests aren't this fine grained yet

Areas of Regression

  • Copy License task

Testing

  • ddev test --integration passes
  • Manual test:
    • delete a license header from one of the .dart files that has it
    • run ddev copy-license (should re-add that license header)
    • run ddev format --check (should report that the code is good to go!)

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@maxwellpeterson-wf
Copy link
Member

+1

@trentgrover-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Make copy license task compatible with dart formatter CP-852 Make copy license task compatible with dart formatter Aug 19, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • ran integration tests locally
    • removed license header and re-ran dartfmt to ensure no changes were made
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 19, 2015
CP-852 Make copy license task compatible with dart formatter
@jayudey-wf jayudey-wf merged commit fba1969 into master Aug 19, 2015
@trentgrover-wf trentgrover-wf deleted the lic branch August 19, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants