Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

Resolves #67. dart_style range is too narrow and causes dependency version conflicts when installed next to many other projects.

Changes

  • Update the pubspec.yaml to accept any dart_style version within >=0.1.8 <0.3.0
  • Update the test fixtures accordingly
  • Update the install instructions in the readme

Areas of Regression

  • Installation in other projects

Testing

  • CI passes.
  • Try installing this branch of dart_dev along with web-skin-dart and ensure that no conflicts arise during installation.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@evanweible-wf evanweible-wf added this to the 1.0.1 milestone Sep 3, 2015
@trentgrover-wf
Copy link
Contributor

+1

@jayudey-wf jayudey-wf changed the title Widen dart_style range to include ^0.1.8 CP-960 Widen dart_style range to include ^0.1.8 Sep 3, 2015
@maxwellpeterson-wf
Copy link
Member

+1

@codecov-io
Copy link

Current coverage is 48.05%

Merging #69 into master will not affect coverage as of 045e33e

Powered by Codecov. Updated on successful CI builds.

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that I was able to install into a project that was using dart_style 1.8 or greater
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Sep 3, 2015
CP-960 Widen dart_style range to include ^0.1.8
@jayudey-wf jayudey-wf merged commit 8928fea into master Sep 3, 2015
@evanweible-wf evanweible-wf deleted the dart_style-range branch November 24, 2015 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase the dependency range for dart_style

6 participants