Skip to content

Conversation

@evanweible-wf
Copy link
Contributor

Issue

  • The readme has several formatting errors when rendered on pub.dartlang.org (Fix readme formatting on pub #48)
  • The changelog is missing the updates that have been merged since 1.0.0

Changes

Displaying the "rich diff" for these files will be helpful since I changed the line length throughout the README and I switched to HTML tables from GitHub's simpler table syntax.

Areas of Regression

n/a

Testing

n/a - we can't really determine how this will look on pub.dartlang.org until it's published there.

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@codecov-io
Copy link

Current coverage is 48.05%

Merging #70 into master will not affect coverage as of 426a77a

Powered by Codecov. Updated on successful CI builds.

@maxwellpeterson-wf
Copy link
Member

+1

@evanweible-wf
Copy link
Contributor Author

TODO

@jayudey-wf jayudey-wf changed the title Fix formatting of README, update CHANGELOG CP-961 Fix formatting of README, update CHANGELOG Sep 3, 2015
@evanweible-wf
Copy link
Contributor Author

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf rebased on latest master, added the change from #69 to the changelog.

@trentgrover-wf
Copy link
Contributor

+1
@jayudey-wf docs only change

@maxwellpeterson-wf
Copy link
Member

+1

1 similar comment
@dustinlessard-wf
Copy link

+1

@jayudey-wf
Copy link
Contributor

QA +1 doc change only

Merging into master

jayudey-wf added a commit that referenced this pull request Sep 4, 2015
CP-961 Fix formatting of README, update CHANGELOG
@jayudey-wf jayudey-wf merged commit abad509 into master Sep 4, 2015
@evanweible-wf evanweible-wf deleted the readme-formatting branch November 24, 2015 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix readme formatting on pub

7 participants