CP-962 Delete first temporary coverage file.

[evanweible-wf]

Issue

#45

Changes

Source:

• Delete the entire collections/ directory that holds the temporary collection files after they have been read and merged.

Tests:

• n/a

Areas of Regression

• coverage

Testing

• on master:
  • ddev coverage --integration
  • verify that temp file in coverage/collections/ was not deleted
• on this branch
  • ddev coverage --integration
  • verify that temp directory coverage/collections/ was deleted entirely

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

[maxwellpeterson-wf]

+1

[codecov-io]

Current coverage is 48.05%

Merging #71 into master will not affect coverage as of 1406afa

Powered by Codecov. Updated on successful CI builds.

[dustinlessard-wf]

+1

[trentgrover-wf]

+1
@jayudey-wf ready for merge

[evanweible-wf]

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf

At @jayudey-wf's suggestion, I'm now deleting the collections/ directory that would contain all of these temporary files instead of deleting each individual file. Should be faster, too.

[trentgrover-wf]

+1
good catch @jayudey-wf

[evanweible-wf]

@maxwellpeterson-wf @dustinlessard-wf

[maxwellpeterson-wf]

+1

[evanweible-wf]

@jayudey-wf ready for merge

[jayudey-wf]

QA Resource Approval: +10

• Testing instruction
• Dev +1's
• Dev/QA +10 with detail of what was tested
  • installed branch into a dart project and verified that collection directory was being appropriately deleted
• Unit test created/updated
• All unit tests pass

Merging into master.