Skip to content

CP-962 Delete first temporary coverage file. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2015
Merged

CP-962 Delete first temporary coverage file. #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/src/tasks/coverage/api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,19 @@ class CoverageTask extends Task {
/// Directory containing the generated coverage report.
Directory get report => _outputDirectory;

/// Path to the directory where collections will be temporarily stored.
Directory get _collections =>
new Directory(path.join(_outputDirectory.path, 'collection/'));

/// All test files (expanded from the given list of test paths).
/// This is the exact list of tests that were run for coverage collection.
Iterable<String> get tests => _files.map((f) => f.path);

Future _collect() async {
List<File> collections = [];
for (int i = 0; i < _files.length; i++) {
File collection = new File(path.join(
_outputDirectory.path, 'collection', '${_files[i].path}.json'));
File collection =
new File(path.join(_collections.path, '${_files[i].path}.json'));
int observatoryPort;

// Run the test and obtain the observatory port for coverage collection.
Expand Down Expand Up @@ -300,8 +304,8 @@ class CoverageTask extends Task {
for (int i = 1; i < collections.length; i++) {
Map coverageJson = JSON.decode(collections[i].readAsStringSync());
mergedJson['coverage'].addAll(coverageJson['coverage']);
collections[i].deleteSync();
}
_collections.deleteSync(recursive: true);

File coverage = new File(path.join(_outputDirectory.path, 'coverage.json'));
if (coverage.existsSync()) {
Expand Down