CP-1129 Add flag to automatically start pub serve when running tests/coverage

[greglittlefield-wf]

Ultimate Problem

Tests and coverage currently cannot be run with files served from a Pub server.

See #79.

Solution

• Add PubServeTask
  • Allows creation and management of pub serve instances.
• Add pub-serve CLI option and pubServe config option to test/coverage tasks.
  • Automatically spins up a Pub server that is used to run the tests.
• Add integration tests for dart_dev coverage/dart_dev test in projects that require a Pub server.

Other changes

Tweak Reporter.logGroup code to be more flexible, and indent for multiline Stream events.

Testing

• Verify that integration tests for test/coverage tasks pass.
• Verify that a real consumer package can run dart_dev test/dart_dev coverage using a pub server.
  • E.g., web_skin_dart with transformer code gen: https://ci.webfilings.com/build/417851
• Verify that pub serve output is well-formatted.

---

FYA: @evanweible-wf @trentgrover-wf
FYI: @jacehensley-wf @aaronlademann-wf

[greglittlefield-wf]

I'd like to log some output here... At the very least, an indication that the pub server is starting, but ideally the pub serve output up until it starts.

Should pubServeTask be a field on TestTask, so that it can be accessed and logged accordingly in test/cli.dart?

[evanweible-wf]

Yeah at this point, that's probably what I would do. You could break it up into two different parts - the logs up until the server is ready, and the remainder. That way you could print the first part immediately and the rest of it when the server is stopped.

[evanweible-wf]

@greglittlefield-wf I think your approach here is fine. As you've seen, the current dart_dev architecture makes this feel a bit hacky, and it's definitely something I want to improve in 2.0.0. But for now, this seems to me like it should work

[greglittlefield-wf]

Cool, I'll proceed with this approach and work toward finalizing it. Thanks for the feedback!

[codecov-io]

Current coverage is 45.12%

Merging #92 into master will decrease coverage by -2.93% as of 16761fa

Powered by Codecov. Updated on successful CI builds.

[greglittlefield-wf]

This is ready for final review. Any clue as to why tests are timing out on Travis? They seem to run fine locally.

[greglittlefield-wf]

Hmm, now that I think about it, if we're passing in additionalArgs: ['test'] to startPubServe, this stream will almost assuredly contain only one event.

This should probably be changed to:

PubServeInfo serveInfo = await pubServeTask.serveInfos.first;
if (!path.isWithin(serveInfo.directory, htmlFile.path)) {
  throw '`pub serve` directory `${serveInfo.directory}` does not contain test file `${htmlFile.path}`.';
}

[evanweible-wf]

Travis CI failure is an issue with Dart 1.13, I'm looking into it

[greglittlefield-wf]

The diff for this section is easier to look at if you ignore whitespace changes.

[evanweible-wf]

This should fix the CI failure once merged: #98

[trentgrover-wf]

+1

[rmconsole3-wf]

@greglittlefield-wf This pull request has merge conflicts, please resolve.

[greglittlefield-wf]

Merge conflicts have been resolved, and it looks like the build is passing now. Thanks, @evanweible-wf!

[evanweible-wf]

@greglittlefield-wf This looks great! Could you add this config option to the readme?

[greglittlefield-wf]

@evanweible-wf Yup! Added in 851ae16.

[evanweible-wf]

+1

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf any of you care to take a look as well?

After that, last step would be a rebase and a squash into a single commit @greglittlefield-wf

[greglittlefield-wf]

@evanweible-wf Rebased and squashed.

[maxwellpeterson-wf]

+1

[evanweible-wf]

+1

[dustinlessard-wf]

+1 cool

[trentgrover-wf]

+1
@jayudey-wf ready for merge

[jayudey-wf]

do you think we need to add an update to the readme about ensuring that you have this in your pubspec.yaml if you want to serve your tests?

- test/pub_serve:
    $include: test/**_test{.*,}.dart

[greglittlefield-wf]

@jayudey-wf That's a good idea, I'll add that.

[greglittlefield-wf]

K, added info to README about setting up test to work with transformers in greglittlefield-wf@1855b61. Needs a +1.

@evanweible-wf Should I squash that commit in as well?

[evanweible-wf]

@greglittlefield-wf sure, might as well. Readme changes look good

[greglittlefield-wf]

Squashed and pushed.

[maxwellpeterson-wf]

+1

[evanweible-wf]

+1 @jayudey-wf ready for merge.

[jayudey-wf]

QA Resource Approval: +10

• Testing instruction
• Dev +1's
• Dev/QA +10 with detail of what was tested
  • verified that tests were passing, installed into two separate projects and made sure that test and coverage were still working as expected w/ and w/o the pub server going, pub serve logging looked ok
• Unit test created/updated
• All unit tests pass

Merging into master.