Skip to content

Conversation

@jayudey-wf
Copy link
Contributor

Issue

Changes

Source:

  • Start a pub serve process and run browser tests through there for coverage purposes

Tests:

  • Current tests provide adequate coverage

Areas of Regression

  • Coverage

Testing

  • Run coverage and ensure that browser based tests are still being reported

Code Review

@dustinlessard-wf
Copy link

+1

@codecov-io
Copy link

Current coverage is 48.05%

Merging #95 into master will not affect coverage as of 821cdf2

Powered by Codecov. Updated on successful CI builds.

@jayudey-wf jayudey-wf closed this Nov 16, 2015
@evanweible-wf evanweible-wf reopened this Nov 18, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all the commented out code?

@trentgrover-wf
Copy link
Contributor

dartfmt fail

@jayudey-wf
Copy link
Contributor Author

troubleshooting effort fails

@greglittlefield-wf
Copy link
Contributor

@jayudey-wf Whoops, looks like there's been some overlap here...

#92 Includes functionality to start a pub server when running coverage.

@jayudey-wf
Copy link
Contributor Author

@greglittlefield-wf I'll close mine as yours looks more comprehensive and I can't figure out why mine is failing on travis...

@jayudey-wf jayudey-wf closed this Nov 19, 2015
@greglittlefield-wf
Copy link
Contributor

Can't figure out why mine is failing, either... 😄

@jayudey-wf jayudey-wf deleted the coverage-on-localhost branch June 27, 2016 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants