Fix ctrie tests #100
Merged
Fix ctrie tests #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trie/ctrie/ctrie_test.go
Outdated
Contributor
There was a problem hiding this comment.
Does it make more sense for this to be
for range expected {
<-iter
}
Contributor
Author
There was a problem hiding this comment.
Probably. Does that for syntax work with go1.3?
Contributor
There was a problem hiding this comment.
for _ := range expected {
}then?
Contributor
Author
|
Looks like an unrelated test failed. |
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Contributor
Author
|
Looks like CI is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly certain this fixes the sporadic issues happening with the ctrie tests (#99). This also should make the tests quite a bit faster.
@alexandercampbell-wf @dustinhiatt-wf @stevenosborne-wf