WADMIN-9939 Make enum type checks less restrictive #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaengraham-wf
approved these changes
Oct 7, 2025
btr-rmconsole-5
bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
andrewmumm-wk
approved these changes
Oct 7, 2025
tristanduyvejonck-wk
changed the title
Author
|
QA +10 View After consuming this change |
Author
|
@Workiva/release-management-p |
nilsbifano-wk
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Unique list does not mean that a list needs values.
The JSON Schema spec doesn't even require that these values MUST be unique, but that is a different issue: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#enum
How it was fixed:
Make empty lists valid for enum types
Testing suggestions:
Potential areas of regression: