Skip to content

CPLAT-7550 Change open attribute typing to bool#351

Merged
rmconsole5-wk merged 1 commit intomasterfrom
CPLAT-7550-update-attribute-typing
Oct 3, 2019
Merged

CPLAT-7550 Change open attribute typing to bool#351
rmconsole5-wk merged 1 commit intomasterfrom
CPLAT-7550-update-attribute-typing

Conversation

@joebingham-wk
Copy link
Contributor

Motivation

To ensure that over_react's DOM elements have the same attributes, and attribute behavior, as React, we should update the open attribute to be a bool.

Changes

  • Change open from dynamic to bool.

Release Notes

  • Update the open HTML attribute typing to match that of the JavaScript community (and React specifically).

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@aaronlademann-wf @greglittlefield-wf @kealjones-wk @sydneyjodon-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants