Skip to content

CPLAT-7607 [Dart 1] Improve handling of “repeat” errors thrown from components wrapped by an ErrorBoundary#352

Merged
rmconsole3-wf merged 7 commits intomaster_dart1from
3.0.0/error-boundary-improvements+dart1
Oct 8, 2019
Merged

CPLAT-7607 [Dart 1] Improve handling of “repeat” errors thrown from components wrapped by an ErrorBoundary#352
rmconsole3-wf merged 7 commits intomaster_dart1from
3.0.0/error-boundary-improvements+dart1

Conversation

@aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf added this to the 3.0.0 milestone Oct 3, 2019
@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner October 3, 2019 21:51
@aviary2-wf
Copy link

aviary2-wf commented Oct 3, 2019

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(3) Security relevant changes were detected
  • Watched keyword innerHtml in lib/src/component/error_boundary.dart line(s) ['325'] added
  • Watched keyword InnerHtml in lib/src/component/error_boundary.dart line(s) ['349'] added
  • Watched keyword dangerouslySetInnerHTML in lib/src/component/error_boundary.dart line(s) ['350'] added
  • Action Items

    • Obtain a security review; reviewer should pay special attention to insights listed above
    • Verify aviary.yaml coverage of security relevant code

    Questions or Comments? Reach out on Slack: #support-infosec.

    @codecov-io
    Copy link

    Codecov Report

    Merging #352 into master_dart1 will decrease coverage by 0.06%.
    The diff coverage is 81.25%.

    @@               Coverage Diff               @@
    ##           master_dart1    #352      +/-   ##
    ===============================================
    - Coverage         90.16%   90.1%   -0.05%     
    ===============================================
      Files                36      36              
      Lines              1828    1868      +40     
    ===============================================
    + Hits               1648    1683      +35     
    - Misses              180     185       +5

    @maxwellpeterson-wf
    Copy link
    Member

    +1 security

    • Our CSP protects us from any potential XSS made possible by this change.

    # Conflicts:
    #	lib/src/component/error_boundary.dart
    # Conflicts:
    #	lib/src/component/error_boundary.over_react.g.dart
    # Conflicts:
    #	lib/src/component/error_boundary.dart
    + and add more test coverage for edge cases involving `dangerouslySetInnerHTML`
    
    # Conflicts:
    #	test/over_react/component/error_boundary_test.dart
    @greglittlefield-wf
    Copy link
    Contributor

    +10

    @maxwellpeterson-wf
    Copy link
    Member

    +1 security refresh

    @greglittlefield-wf
    Copy link
    Contributor

    @Workiva/release-management-p

    @rmconsole3-wf rmconsole3-wf merged commit 154ec26 into master_dart1 Oct 8, 2019
    @rmconsole3-wf rmconsole3-wf deleted the 3.0.0/error-boundary-improvements+dart1 branch October 8, 2019 18:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    7 participants