CPLAT-7607 [Dart 1] Improve handling of “repeat” errors thrown from components wrapped by an ErrorBoundary#352
Merged
rmconsole3-wf merged 7 commits intomaster_dart1from Oct 8, 2019
Conversation
+ Dart 1 port of the fix from master (de99fd1)
Security InsightsThe items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact. (3) Security relevant changes were detectedinnerHtml in lib/src/component/error_boundary.dart line(s) ['325'] addedInnerHtml in lib/src/component/error_boundary.dart line(s) ['349'] addeddangerouslySetInnerHTML in lib/src/component/error_boundary.dart line(s) ['350'] addedAction Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Codecov Report
@@ Coverage Diff @@
## master_dart1 #352 +/- ##
===============================================
- Coverage 90.16% 90.1% -0.05%
===============================================
Files 36 36
Lines 1828 1868 +40
===============================================
+ Hits 1648 1683 +35
- Misses 180 185 +5 |
Member
|
+1 security
|
# Conflicts: # lib/src/component/error_boundary.dart
# Conflicts: # lib/src/component/error_boundary.over_react.g.dart
# Conflicts: # lib/src/component/error_boundary.dart
+ and add more test coverage for edge cases involving `dangerouslySetInnerHTML` # Conflicts: # test/over_react/component/error_boundary_test.dart
Contributor
|
+10 |
Member
|
+1 security refresh |
Contributor
|
@Workiva/release-management-p |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@greglittlefield-wf @kealjones-wk @joebingham-wk @sydneyjodon-wk