RM-73320 Release over_react_test 2.9.4 (render util hotfix)#100
Merged
Conversation
+ These were previously deprecated / replaced by the new `logsPropError*` matchers. However, the new matchers are only suitable for testing `PropError`s that happen within `UiComponent2.propTypes`. `PropError`s can still be thrown elsewhere in components to produce full-blown RTEs - so the old matchers are still useful for testing that.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
commented
May 5, 2020
|
|
||
| test('(UiComponent2)', () { | ||
| final renderedInstance = render(Test2()); | ||
| expect(Test2(getProps(renderedInstance)).children, isEmpty); |
Contributor
Author
There was a problem hiding this comment.
I verified that this test fails without the analogous change in react_util.dart
Contributor
Author
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hotfix addresses two issues recently released from this library:
throwsPropError*matchers were previously deprecated / replaced by the newlogsPropError*matchers. However, the new matchers are only suitable for testingPropErrors that happen withinUiComponent2.propTypes.PropErrors can still be thrown elsewhere in components to produce full-blown RTEs - so the old matchers are still useful for testing that.render()utility function had different behavior betweenUiComponentandUiComponent2instances when provided with aUiPropsinstance(a.k.a an uninvoked builder).@greglittlefield-wf @joebingham-wk @corwinsheahan-wf @sydneyjodon-wk