RM-73871 Release over_react_test 2.9.5 (MSIE 11 Object.values HOTFIX)#101
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
approved these changes
May 29, 2020
| try { | ||
| propValues = props.values; | ||
| } catch (_) { | ||
| // IE 11 doesn't support Object.values |
Contributor
There was a problem hiding this comment.
We should also fix this by polyfilling it in react-dart, since propsMap.values could also be used in prod
Contributor
Author
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The new prop forwarding test utilities make use of
Object.values, but MSIE 11 doesn't support it. This causes consumer test failures of the form:Changes
Shim the functionality so that consumer tests can run in MSIE 11.
Release Notes
Shim
Object.valuesfor MSIE 11