Skip to content

RM-73871 Release over_react_test 2.9.5 (MSIE 11 Object.values HOTFIX)#101

Merged
rmconsole3-wf merged 2 commits into
masterfrom
msie11-object-values-shim
Jun 5, 2020
Merged

RM-73871 Release over_react_test 2.9.5 (MSIE 11 Object.values HOTFIX)#101
rmconsole3-wf merged 2 commits into
masterfrom
msie11-object-values-shim

Conversation

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

Motivation

The new prop forwarding test utilities make use of Object.values, but MSIE 11 doesn't support it. This causes consumer test failures of the form:

NoSuchMethodError: Object doesn't support property or method 'values' (Error 438)

<some_test_file>.dart.js <line>:<col>   L.JsBackedMap.prototype.get$values
<some_test_file>.dart.js <line>:<col>    J.get$values$x
<some_test_file>.dart.js <line>:<col>   P.MapView.prototype.get$values
<some_test_file>.dart.js <line>:<col>  E.getForwardingTargets
<some_test_file>.dart.js <line>:<col>   E._testPropForwarding_closure.prototype.call$0

Changes

Shim the functionality so that consumer tests can run in MSIE 11.

Release Notes

Shim Object.values for MSIE 11

@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review May 29, 2020 13:48
Copy link
Copy Markdown
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

try {
propValues = props.values;
} catch (_) {
// IE 11 doesn't support Object.values
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also fix this by polyfilling it in react-dart, since propsMap.values could also be used in prod

@aaronlademann-wf
Copy link
Copy Markdown
Contributor Author

@Workiva/release-management-pp

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 4b1c3a9 into master Jun 5, 2020
@rmconsole3-wf rmconsole3-wf deleted the msie11-object-values-shim branch June 5, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants