Skip to content

CPLAT-12003 RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives)#102

Merged
rmconsole3-wf merged 10 commits into
masterfrom
fix-prop-forwarding-tests
Sep 3, 2020
Merged

CPLAT-12003 RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives)#102
rmconsole3-wf merged 10 commits into
masterfrom
fix-prop-forwarding-tests

Conversation

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

@aaronlademann-wf aaronlademann-wf commented Jun 9, 2020

This release addresses:

  • Fix prop forwarding tests false positives

    Tests that had commonComponentTests.getUnconsumedPropKeys() returning a list of
    keys that included keys within mixins that were actually being consumed by the component
    were not failing as expected.

    e.g. this situation should have resulted in test failures, but it did not:

    Component's consumedProps:

    @override
    get consumedProps => propsMeta.forMixins({
      SomePropsMixin,
    });

    Component's commonComponentTests:

    group('common component tests', () {
      commonComponentTests(ComponentFactory, getUnconsumedProps: (propsMeta) => [
        ...propsMeta.forMixin(SomePropsMixin).keys,
      ]);
    });

+ When a component is consuming props that are specified as unconsumed via `commonComponentTests.getUnconsumedPropKeys()`, the test should fail.
+ Also improved misc. typing, test failure messaging, and added `@isTest` / `@isTestGroup` annotations.
@aviary3-wk
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf changed the title Fix prop forwarding tests RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives) Jun 9, 2020
@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review June 10, 2020 14:48
Comment thread lib/src/over_react_test/common_component_util.dart
Comment thread lib/src/over_react_test/common_component_util.dart Outdated
Comment thread lib/src/over_react_test/common_component_util.dart Outdated
@greglittlefield-wf greglittlefield-wf changed the title RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives) Release over_react_test 2.9.6 (Fix prop forwarding test false positives) Aug 25, 2020
@rmconsole3-wf rmconsole3-wf changed the title Release over_react_test 2.9.6 (Fix prop forwarding test false positives) RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives) Aug 25, 2020
@rmconsole3-wf rmconsole3-wf changed the title RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives) CPLAT-12003 RM-76349 Release over_react_test 2.9.6 (Fix prop forwarding test false positives) Aug 25, 2020
Comment thread lib/src/over_react_test/common_component_util.dart Outdated
+ Instead of pinning the Dart SDK version
+ Something in Dart core changed recently where a `DivElement` in minified JS used to be `DivElement:<div>` but is now `minified:jQ:<div>`.
Comment thread lib/src/over_react_test/common_component_util.dart Outdated
Comment thread lib/src/over_react_test/common_component_util.dart Outdated
Comment thread lib/src/over_react_test/common_component_util.dart
Copy link
Copy Markdown
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@aaronlademann-wf
Copy link
Copy Markdown
Contributor Author

+1 to 3aeb841

@aaronlademann-wf
Copy link
Copy Markdown
Contributor Author

+1 @Workiva/release-management-pp

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 3429e94 into master Sep 3, 2020
@rmconsole3-wf rmconsole3-wf deleted the fix-prop-forwarding-tests branch September 3, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants