Skip to content

CPLAT-11842 Update instructions in TestJacket when using function components#105

Merged
rmconsole2-wf merged 3 commits into
masterfrom
update-function-component-guidance
Aug 12, 2020
Merged

CPLAT-11842 Update instructions in TestJacket when using function components#105
rmconsole2-wf merged 3 commits into
masterfrom
update-function-component-guidance

Conversation

@greglittlefield-wf
Copy link
Copy Markdown
Contributor

Motivation

I noticed that the errors encountered in TestJacket when using function components could use just a touch more information to help guide users.

Changes

  • Add note about using Wrapper component to enable getByTestId
  • Add note about using mountNode directly if possible
  • Update doc comments to match error messages

Release Notes

  • Add more info around function components in TestJacket error messages and doc comments

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@rmconsole2-wf rmconsole2-wf changed the title Update instructions in TestJacket when using function components CPLAT-11842 Update instructions in TestJacket when using function components Aug 7, 2020
@aviary3-wk
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Comment thread lib/src/over_react_test/jacket.dart Outdated
willdrach-wk
willdrach-wk previously approved these changes Aug 7, 2020
Copy link
Copy Markdown

@willdrach-wk willdrach-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is nice to know.

Comment thread lib/src/over_react_test/jacket.dart Outdated
Comment thread lib/src/over_react_test/jacket.dart Outdated
@greglittlefield-wf
Copy link
Copy Markdown
Contributor Author

Feedback addressed, and I cherry-picked a commit from Aaron's PR to fix Travis

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

QA +1

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

@Workiva/release-management-pp

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit 4d5b57a into master Aug 12, 2020
@rmconsole2-wf rmconsole2-wf deleted the update-function-component-guidance branch August 12, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants