Skip to content

Widen OverReact constraint in preparation for v4.0.0#108

Merged
rm-astro-wf merged 2 commits into
masterfrom
widen-over-react-constraint
Nov 25, 2020
Merged

Widen OverReact constraint in preparation for v4.0.0#108
rm-astro-wf merged 2 commits into
masterfrom
widen-over-react-constraint

Conversation

@joebingham-wk
Copy link
Copy Markdown
Contributor

Motivation

Because OverReact and over_react_test rely on each other, OverReact 4.0.0 cannot resolve its dependencies unless over_react_test can resolve with OverReact 4.0.0.

Changes

Widen the acceptable over_react version range.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Comment thread pubspec.yaml Outdated
meta: ^1.1.0
over_react: ^3.5.3
over_react: ">=3.5.3 <5.0.0"
react: ^5.5.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be widened

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yep, thank you @greglittlefield-wf! Updated!

Copy link
Copy Markdown
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit a2429f0 into master Nov 25, 2020
@rm-astro-wf rm-astro-wf deleted the widen-over-react-constraint branch November 25, 2020 22:20
@joebingham-wk joebingham-wk mentioned this pull request Dec 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants