Add Component Version Auto Detection#89
Merged
rmconsole7-wk merged 3 commits intomasterfrom Mar 4, 2020
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Contributor
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the common component tests require the flag
isComponent2to be set to true in order to run tests specific toComponent2. This can be automated, eliminating the need for the flag to be set.Changes
ReactElementtype to determine if the version is one or two.Release Notes
ReactElementtype check tocommonComponentTests.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@aaronlademann-wf @greglittlefield-wf @kealjones-wk
QA Checklist
Component2test suite without setting theisComponent2flag.Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: