Skip to content

Add Component Version Auto Detection#89

Merged
rmconsole7-wk merged 3 commits intomasterfrom
auto-detect-component2
Mar 4, 2020
Merged

Add Component Version Auto Detection#89
rmconsole7-wk merged 3 commits intomasterfrom
auto-detect-component2

Conversation

@joebingham-wk
Copy link
Copy Markdown
Contributor

Motivation

Currently the common component tests require the flag isComponent2 to be set to true in order to run tests specific to Component2. This can be automated, eliminating the need for the flag to be set.

Changes

  • Add a check to the ReactElement type to determine if the version is one or two.

Release Notes

  • Add automated ReactElement type check to commonComponentTests.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@aaronlademann-wf @greglittlefield-wf @kealjones-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • Publink this branch to web_skin_dart's react-16-post-upgrade-wip branch and run a Component2 test suite without setting the isComponent2 flag.
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Copy Markdown
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

@Workiva/release-management-pp

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit af2cb0e into master Mar 4, 2020
@rmconsole7-wk rmconsole7-wk deleted the auto-detect-component2 branch March 4, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants