RM-72266 Release over_react_test 2.9.1 (HOTFIX)#97
Merged
rmconsole7-wk merged 4 commits intomasterfrom Apr 16, 2020
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
evanweible-wf
approved these changes
Apr 16, 2020
Contributor
|
QA +1 @Workiva/release-management-p |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Trying to render a component via
getPropsMetadirectly inside ofcommonComponentTestscauses issues when the providedfactoryhas required props that come fromsetUp-initialized variables.For example:
This is because it's run before the consumer's
setUpblock.Solution
Move
getPropsMetacall to insidetestblock to ensure consumersetUpis called firstRequested by: @greglittlefield-wf
Diff Between Last Tag and Proposed Release: 2.9.0...Workiva:release_over_react_test_2.9.1
Diff Between Last Tag and New Tag: 2.9.0...2.9.1
The logs for the request that created this PR can be found here