Skip to content

RM-72266 Release over_react_test 2.9.1 (HOTFIX)#97

Merged
rmconsole7-wk merged 4 commits intomasterfrom
release_over_react_test_2.9.1
Apr 16, 2020
Merged

RM-72266 Release over_react_test 2.9.1 (HOTFIX)#97
rmconsole7-wk merged 4 commits intomasterfrom
release_over_react_test_2.9.1

Conversation

@rmconsole-readonly-wk
Copy link
Copy Markdown
Contributor

@rmconsole-readonly-wk rmconsole-readonly-wk commented Apr 16, 2020

Problem:

Trying to render a component via getPropsMeta directly inside of commonComponentTests causes issues when the provided factory has required props that come from setUp-initialized variables.

For example:

setUp(() {
  store = MyStore();
});

commonComponentTests(() => factory()..store = store);

This is because it's run before the consumer's setUp block.

Solution

Move getPropsMeta call to inside test block to ensure consumer setUp is called first


Requested by: @greglittlefield-wf

Diff Between Last Tag and Proposed Release: 2.9.0...Workiva:release_over_react_test_2.9.1
Diff Between Last Tag and New Tag: 2.9.0...2.9.1

The logs for the request that created this PR can be found here

@rmconsole5-wk rmconsole5-wk changed the title Release over_react_test 2.9.1 RM-72266 Release over_react_test 2.9.1 Apr 16, 2020
@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf greglittlefield-wf changed the title RM-72266 Release over_react_test 2.9.1 RM-72266 Release over_react_test 2.9.1 (HOTFIX) Apr 16, 2020
@greglittlefield-wf
Copy link
Copy Markdown
Contributor

QA +1

@Workiva/release-management-p

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 757c975 into master Apr 16, 2020
@rmconsole7-wk rmconsole7-wk deleted the release_over_react_test_2.9.1 branch April 16, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants