RM-72368 Release over_react_test 2.9.3 (Hotfix to fix prop type expectations)#99
Merged
Merged
Conversation
+ This was missed because the test was only using the first argument of the `logsPropError` function. When both arguments are used, the missing period causes failing tests in consumer repos. + Note that the period that was missing from `logsPropError` is present in the deprecated `throwsPropError` matcher that it replaces.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Contributor
Author
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
logsPropErrormatcher that replaces thethrowsPropErrormatcher had a typo in the message it expects from the logger. It is missing a period.Changes
Release Notes
Fix logsPropError matcher message expectation
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @joebingham-wk @corwinsheahan-wf
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: