Skip to content

RM-72368 Release over_react_test 2.9.3 (Hotfix to fix prop type expectations)#99

Merged
rmconsole5-wk merged 2 commits into
masterfrom
fix-propType-expectations
Apr 29, 2020
Merged

RM-72368 Release over_react_test 2.9.3 (Hotfix to fix prop type expectations)#99
rmconsole5-wk merged 2 commits into
masterfrom
fix-propType-expectations

Conversation

@aaronlademann-wf
Copy link
Copy Markdown
Contributor

Motivation

The logsPropError matcher that replaces the throwsPropError matcher had a typo in the message it expects from the logger. It is missing a period.

Changes

  1. Add the missing period.
  2. Update the tests so that the first and second argument are used - which is the only way the missing period would have caused a test failure.

Release Notes

Fix logsPropError matcher message expectation

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review: @greglittlefield-wf @joebingham-wk @corwinsheahan-wf

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

+ This was missed because the test was only using the first argument of the `logsPropError` function.  When both arguments are used, the missing period causes failing tests in consumer repos.
+ Note that the period that was missing from `logsPropError` is present in the deprecated `throwsPropError` matcher that it replaces.
@aviary3-wk
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Copy Markdown
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@aaronlademann-wf
Copy link
Copy Markdown
Contributor Author

@Workiva/release-management-pp

Copy link
Copy Markdown

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit c5813f5 into master Apr 29, 2020
@rmconsole5-wk rmconsole5-wk deleted the fix-propType-expectations branch April 29, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants