This repository was archived by the owner on May 23, 2023. It is now read-only.
KH-18819: Support Dart 2 by unblocking args ^1.0.0#1
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
| } | ||
|
|
||
| final dashesToCamelCase = new SeparatorCodec("-", splitter: new RegExp(r'[_-]')) | ||
| Codec dashesToCamelCase = new SeparatorCodec("-", splitter: new RegExp(r'[_-]')) |
There was a problem hiding this comment.
As a note of caution, final is a keyword, not a type. Changing this may cause bugs if other areas depend ondashesToCamelCase being immutable. Are you certain this shouldn't be final Codec dashesToCamelCase instead?
- Fix immutable object
|
+1 |
1 similar comment
|
+1 |
Author
|
Found a problem running --help where it does not output all the information it is supposed to. Investigating. |
- Fix help output
|
+1 |
|
QA +1 |
michaelyeager-wf
approved these changes
May 21, 2018
|
RM +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Args 1.0 is required for Dart 2, so this PR increases the range of that dependency and implements strong mode fixes
@aaronlademann-wf @michaelyeager-wf