Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Conversation

@evanweible-wf
Copy link

Issue

At some point, an update to gulp-livereload and/or tiny-lr caused gulp watch:test tasks to fail when running in PhantomJS. These versions are the culprits:

› npm list | grep gulp-livereload
  ├─┬ gulp-livereload@2.1.1

› npm list | grep tiny-lr
  │ └─┬ tiny-lr@0.1.5

This is the error you will see:

INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Mac OS X)]: Connected on socket B1lI2gdGivbzw6IH8qNL with id 20798968
PhantomJS 1.9.8 (Mac OS X) ERROR
  Script error.

Solution

Pin gulp-livereload and tiny-lr:

› npm list | grep gulp-livereload
  ├─┬ gulp-livereload@2.1.0

› npm list | grep tiny-lr
  ├─┬ tiny-lr@0.0.7

Testing

  • All tests pass
  • Consumer of wGulp can install this branch and run gulp watch:test successfully

fya: @trentgrover-wf @maxwellpeterson-wf

@rmconsole-wf
Copy link

    When this pull is merged I will use the following information:
    Version: wGulp 0.7.9
    Release Ticket: CP-456

Last updated on Monday, March 09 11:36 AM CST

@trentgrover-wf
Copy link
Contributor

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

+1

@evanweible-wf
Copy link
Author

@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Pin gulp-livereload and tiny-lr dependencies CP-458 Pin gulp-livereload and tiny-lr dependencies Mar 9, 2015
Conflicts:
	package.json
@jayudey-wf
Copy link
Contributor

go @rmconsole-wf

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that task was able to be run successfully with this change
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Mar 9, 2015
CP-458 Pin gulp-livereload and tiny-lr dependencies
@jayudey-wf jayudey-wf merged commit 9ca4411 into master Mar 9, 2015
@trentgrover-wf trentgrover-wf deleted the livereload branch August 19, 2015 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants