This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix Static Content CI Push#1900
Merged
brunobowden merged 2 commits intoWorldHealthOrganization:masterfrom Jan 10, 2021
Merged
Conversation
brunobowden
requested review from
britannio,
theswerd and
yukuairoy
as code owners
Contributor
Author
|
FYI @advayDev1 @theswerd |
Contributor
matthewblain
left a comment
matthewblain
left a comment
There was a problem hiding this comment.
these ids are in so many places!
- Standard on projectID usage - Correct project id - Remove deprecated code in push script
brunobowden
force-pushed
the
push-static-fix
branch
from
17d09e9 to
67cc4d9
Compare
Contributor
Author
|
@matthewblain - I agree about it being repeated in far too many places. Should be good now. |
matthewblain
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test the change?
CI Push Static Content after merge
Checklist: