Restore symptom checker

[patniemeyer]

This replaces the health check "poster" tab on the home page with the restored symptom checker code from commit: d614c40 and does what is necessary to get it working within the current app.

All lint issues have been fixed and I believe this is working, not withstanding one known issue: that our application styled button does not show the disabled state. I will open an issue for this separately.

Additionally the updated code does not utilize the observable pattern and possibly other app conventions adopted after it was written. We can open issues for those going forward.

I have tested this in the simulator.

[theswerd]

LGTM

[brunobowden]

@patniemeyer - great to get this running again. Main comment is that we'll want to keep around the symptom poster for countries where we can't get the check up tool approved. We should import both of them in to the app and then allow toggling between them using the yaml config.

My concern is that this may require additional work so that the nav bar icon for "Check-Up" can be controlled by the home_index.en.yaml file and be configured. Since that's the case, let's deal with that in another PR and just focus on fixing up the other comments before landing this one.

[stale]

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[brunobowden]

@patniemeyer - this is great. My one thought was that show_symptom_checker would be better as a property of the symptom_checker.en.yaml file and shouldn't be something that the top level app needs to know about. So the idea was that the main page would link to the Check-Up tool and then based on the symptom_checker.en.yaml config, it would either show the symptom page or the symptom checker tool. That has better encapsulation but I'm wary about it being a lot of refactoring work.

[patniemeyer]

@brunobowden Yes, that makes sense. I will move it.

[brunobowden]

Thanks Pat Pat - ideally it’s generic part of the Symptom Checker like a question or a results page. So if you wanted the power, you’d omit all the other sections and just put in the content for the poster. That might be a bit much but go as far as you can.

…

On Sat, Feb 20, 2021 at 5:16 PM Pat Niemeyer ***@***.***> wrote: @brunobowden <https://github.com/brunobowden> Yes, that makes sense. I will move it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1935 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFF3K3T2ISWF2O42TO6D4TTABNGPANCNFSM4XGQXAHQ> .

[patniemeyer]

As suggested I have merged the two pages into one CheckUpPage driven by the symptom_checker yaml. I have tried to follow the ContentWidget pattern found in the app here but something is wrong: It seems that if the widget is built while content is null there is nothing to trigger a rebuild and the page remains empty until something down the line triggers a refresh. It looks like the mobx observable stuff is supposed to cause the content widget to rebuild automatically... but this isn't working for some reason? I'm wondering if any of you are familiar with this code and see something obvious that I'm doing wrong...