Started v2.0 migration#1986
Started v2.0 migration#1986theswerd wants to merge 10 commits intoWorldHealthOrganization:masterfrom
Conversation
brunobowden
left a comment
brunobowden
left a comment
There was a problem hiding this comment.
@theswerd - this looks good to me. What else does it need?
| bool fadeState = true; | ||
|
|
||
| AnimationController _animationController; | ||
| late AnimationController _animationController; |
| notification_permissions: ^0.5.0 | ||
| # observer_provider: 0.0.1+2 | ||
| package_info: "2.0.0" | ||
| # page_view_indicator: ^2.0.4 |
|
just looked over the cache manager - reimplementation should be relatively easy. they provided instructions for moving away from base cache manager. |
|
Thanks Ben. That's encouraging.
…On Thu, Apr 29, 2021 at 3:57 PM Benjamin Swerdlow ***@***.***> wrote:
just looked over the cache manager - reimplementation should be relatively
easy. they provided instructions for moving away from base cache manager.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1986 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFF3K2EODFXXQIROAHL37TTLHP5ZANCNFSM43NOIS3Q>
.
|
|
Cache manager working - only need to re-implement charts |
brunobowden
left a comment
brunobowden
left a comment
There was a problem hiding this comment.
Changes to cache manager look good
All we need is fl_chart now...
| border: InputBorder.none, hintText: 'Enter your country'), | ||
| onChanged: (String value) async { | ||
| List filtered = (widget.countries?.values ?? []).where((element) { | ||
| List filtered = (widget.countries.values).where((element) { |
There was a problem hiding this comment.
This is much cleaner. Good case where null safety enforces better discipline
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Fix runtime errors due to new nullability semantics
| var country; | ||
| if (currentCountryCode != null) | ||
| country = countryList.countries[currentCountryCode]; |
There was a problem hiding this comment.
I was thinking you could simplify this with Conditional Property Access... then I realize that doesn't work and you need to do it this way instead ;-)
There was a problem hiding this comment.
Ah good call on simplifying this bit! After playing around some more, I think we can just do:
final country = countryList.countries[currentCountryCode];
(sorry, I could've sworn this was causing a runtime error but it's working fine for me now 😛)
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
4 participants
In progress
Checklist: