Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Add Korean(ko-kr) translation#372

Closed
tdh8316 wants to merge 7 commits intoWorldHealthOrganization:masterfrom
tdh8316:master
Closed

Add Korean(ko-kr) translation#372
tdh8316 wants to merge 7 commits intoWorldHealthOrganization:masterfrom
tdh8316:master

Conversation

@tdh8316
Copy link
Copy Markdown

@tdh8316 tdh8316 commented Mar 27, 2020

Please follow this checklist. Please check each appropriate box (put an 'x' or check it after creating the PR).

  • Provided detailed pull request description and a succinct title (consider template below for guidance).
  • Tested your changes, especially after any code review iterations.
  • Included any relevant screenshots of UI updates.
  • Followed the Contributor Guidelines.
  • Verified all contributions are properly licensed pursuant to the LICENSE file in the root of the repository.
  • Verified your name is in the content/credits.yaml file (if you want it to be).

After all boxes above are checked, request and receive an Approved review from any team member knowledgable in the area (TODO team member list). Once approved, the team member will assign your review to a Committer or use the needs-merge label.

What does this PR accomplish?

It adds translation for the Korean language.

Did you add any dependencies?

No.

How did you test the change?

With my machine

@hspinks hspinks added the l10n Localization (translations) label Mar 27, 2020
@hspinks hspinks requested a review from sapte91 March 27, 2020 08:29
@advayDev1
Copy link
Copy Markdown
Contributor

advayDev1 commented Mar 27, 2020

Thank you for your contribution. However, please follow our NEW PR checklist/template here:
https://raw.githubusercontent.com/WorldHealthOrganization/app/master/.github/pull_request_template.md - thanks!

Copy link
Copy Markdown

@json469 json469 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be very cautious when translating medical contents and should refer to some form of medical professionals for proof check as it may have significant impact on the users' understanding, behaviour, and most importantly their health.

@tdh8316
Copy link
Copy Markdown
Author

tdh8316 commented Mar 27, 2020

@json469, I agree with you. I should be more cautious. But I thought that I could translate this app because it is not hard content like paper. I'm sorry for my carelessness, I thought what I translated was casual content. Can you advise me on what I can do for the proof check?

@json469
Copy link
Copy Markdown

json469 commented Mar 27, 2020

@json469, I agree with you. I should be more cautious. But I thought that I could translate this app because it is not hard content like paper. I'm sorry for my carelessness, I thought what I translated was casual content. Can you advise me on what I can do for the proof check?

Hey man no worries, that's what PRs are for! I don't think it is strictly and formally a medical guideline (you should always consult with your doctor for that 😄) but yes we should strive our best to translate as correctly as possible. I think you're doing great, feel free to include me in your future translation PRs and also other Korean writing developers so we can all double check. I think there are just few tricky ones that we should be careful of like the above 👍

@sapte91
Copy link
Copy Markdown
Contributor

sapte91 commented Mar 29, 2020

@tdh8316 Thank you so much for your support of this project and for the time you spent on this PR - we’re so humbled by your willingness to jump in! We have an important update on localization for the application: We’ll primarily be sourcing and managing translations from Lingo24, our translation management system. Also, our designs changed, so these translations are now out of date. As such, I’m closing this PR.

We will still need translation volunteers - as our set of supported languages and locales grows, there will be plenty of opportunity to contribute! Our projected needs for the next two months are in native speaker LQA and translations for languages that we cannot support on Lingo24. We apologize that we are still in the early process of figuring out how to manage all the contributions and will have more details soon. Until then, please fill out the volunteer form below and we’ll get back in touch shortly.

https://forms.gle/DTqvaqh4mE7bDe5U7

@sapte91 sapte91 closed this Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

l10n Localization (translations)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants