Merged
Conversation
In the translation from DRAM1->2 and moving to nextflow, the code to take the tophit for the hmm search had a couple bugs in it depending on the hmm db. It would sometimes take just the first hit outputted in the data sheet, it would calcuate the bitscore wrong, and it wouldn't do the info sheets right (since it was calculating bitscore wrong). Now it reports both full sequence bitscore and domain bitscore. It takes the top it and also reports all other hits as well. All of this is done in a generic way so that adding generic hmm support will be trivial for next release after we fix this bug Also add support for metals hmm DB.
madeline-scyphers
added
bug
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: hmm parsing now takes top hit consistently
In the translation from DRAM1->2 and moving to nextflow,
the code to take the tophit for the hmm search had a couple
bugs in it depending on the hmm db. It would sometimes
take just the first hit outputted in the data sheet,
it would calcuate the bitscore wrong, and it wouldn't
do the info sheets right (since it was calculating bitscore
wrong).
Now it reports both full sequence bitscore and domain bitscore.
It takes the top it and also reports all other hits as well.
All of this is done in a generic way so that adding generic hmm
support will be trivial for next release after we fix this bug
Also add support for metals hmm DB.