fix: remove conflict check for heap profiling#219
Merged
hyj1991 merged 1 commit intoX-Profiler:masterfrom Jan 11, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 318 318
=========================================
Hits 318 318 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
不过这几个一起操作还是会互相影响的吧, chrome devtools 还是只能一次操作一个 profiler 的(不过不是很严谨,heap profiling 的时候可以开启 cpu profiling,但是 cpu profiling 的时候就不允许切换 tab 了) |
Member
Author
其实实践中处理问题时同时抓虽然有一些影响,但是能从更多维度看问题,所以不需要限制并行操作 |
legendecas
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由于
node-v12.x已经不在 LTS 版本中,xprofiler可以移除CPU Profiling/Heap Profiling/Heapdump操作之间的冲突检测