Skip to content

fix: remove conflict check for heap profiling#219

Merged
hyj1991 merged 1 commit intoX-Profiler:masterfrom
hyj1991:master
Jan 11, 2023
Merged

fix: remove conflict check for heap profiling#219
hyj1991 merged 1 commit intoX-Profiler:masterfrom
hyj1991:master

Conversation

@hyj1991
Copy link
Copy Markdown
Member

@hyj1991 hyj1991 commented Jan 11, 2023

由于 node-v12.x 已经不在 LTS 版本中,xprofiler 可以移除 CPU Profiling / Heap Profiling / Heapdump 操作之间的冲突检测

@hyj1991 hyj1991 requested a review from legendecas January 11, 2023 03:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2023

Codecov Report

Merging #219 (3c197c4) into master (5d236be) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          318       318           
=========================================
  Hits           318       318           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@legendecas
Copy link
Copy Markdown
Member

不过这几个一起操作还是会互相影响的吧, chrome devtools 还是只能一次操作一个 profiler 的(不过不是很严谨,heap profiling 的时候可以开启 cpu profiling,但是 cpu profiling 的时候就不允许切换 tab 了)

@hyj1991
Copy link
Copy Markdown
Member Author

hyj1991 commented Jan 11, 2023

不过这几个一起操作还是会互相影响的吧, chrome devtools 还是只能一次操作一个 profiler 的(不过不是很严谨,heap profiling 的时候可以开启 cpu profiling,但是 cpu profiling 的时候就不允许切换 tab 了)

其实实践中处理问题时同时抓虽然有一些影响,但是能从更多维度看问题,所以不需要限制并行操作

@hyj1991 hyj1991 merged commit 623b0d2 into X-Profiler:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants