Missing ErrorExec function

[leon-ts]

VO has an ErrorExec function that call the currently installed error function and error block. In fact, it is a wrapper for the following expression:
Eval( ErrorBlock(), oError )
Is it possible to add this function (ErrorExec) to X#?

P.S. We are using a modified error message box using X#'s built-in XSharp.ErrorDialog class. Therefore, the ErrorDialog function is not suitable for us.

[RobertvanderHulst]

Sure, I will add that.
In the mean time you can also add that function to your own code, so it compiles.

[RobertvanderHulst]

There is a (small) difference: ErrorExec() in VO takes a pointer to an ERRINFO structure.
The ErrorBuild function in VO also took an ERRINFO structure.
We have implemented ErrorBuild and it takes an Exception.
Will do the same for ErrorExec(): It will take an exception, call ErrorBuild to create the Error object and will then eval the codeblock inside ErrorBlock() and pass the error as argument.

[leon-ts]

Robert,
I assumed that in X# the ErrorExec function would be defined like this:

FUNCTION ErrorExec(oError AS Error) AS USUAL PASCAL
    RETURN Eval( ErrorBlock(), oError )

Well, there may still be an overload for the Exception type.

[leon-ts]

I did not see in front of my message that you have already implemented this function.

[leon-ts]

For example, a typical use case:

BEGIN SEQUENCE
   ...
RECOVER USING xError
   IF ( xError IS Error VAR oError )
       ErrorExec(oError)
   ENDIF
END SEQUENCE

[RobertvanderHulst]

Leonid,

I assumed that in X# the ErrorExec function would be defined like this:

FUNCTION ErrorExec(oError AS Error) AS USUAL PASCAL
   RETURN Eval( ErrorBlock(), oError )

Well, there may still be an overload for the Exception type.

The ErrorBuild() and ErrorExec() in VO are declared as:

_DLL FUNCTION ErrorBuild (ptrERRINFO AS ERRINFO) AS ERROR  PASCAL:VO28RUN.ErrorBuild
_DLL FUNCTION ErrorExec  (ptrERRINFO AS ERRINFO) AS USUAL  PASCAL:VO28RUN.ErrorExec

ERRINFO is a structure because many of the subsystems in VO (such as the RDD system) were written in a non oop C language.
ErrrorExec in VO does something like this:

VAR oError := ErrorBuild(ptrERRINFO)
  IF oError != NULL
  VAR cbError := ErrorBlock()
  IF cbError != NULL
     var result := cbError:Eval(oError)
      // check for the type of result
      // check to see if the error object has CanRetry, CanDefault or CanSubstitute set
      // depending on the result type, either set the # of retries to 0, 
      // or when one of these options is set return a default value or substituted value
      RETURN result
  ELSE 
    // Error Handling
  ENDIF
  ELSE 
    // Error Handling
ENDIF

Since we do not really support CanRetry, CanDefault and CanSubstitute I have left that out of the code.

[leon-ts]

Robert,

Since we do not really support CanRetry, CanDefault and CanSubstitute I have left that out of the code.

Yes I know. Therefore, in my first post, I added to P.S. that we are not using the ErrorDialog function, as it displays useless Ignore and Retry buttons. Therefore, we directly use the XSharp.ErrorDialog class (we disabled unnecessary buttons and so on in it).

As far as the ErrorExec function is concerned, I am of course aware that in X# error information is passed through the Error (Exception) class, instead of the ERRINFO structure in the VO. Therefore, while creating this ticket, I assumed that the ErrorExec function would be modified specifically for X#, accepting its "rules of the game". In fact, this function is simply needed as a wrapper so that you do not write in the code every time: Eval( ErrorBlock(), oError )

[cpyrgas]

Added and seems to work correctly.

[leon-ts]

Robert,
The final implementation of this function causes the Error type to be instantiated three times!

FUNCTION ErrorExec(pErrInfo AS Exception) AS USUAL
    local cbError as CODEBLOCK
    local oError  as XSharp.Error
    cbError := ErrorBlock()
    oError := ErrorBuild(XSharp.Error{pErrInfo})
    RETURN cbError:Eval(oError)

For example:

RECOVER USING oError
    ErrorExec(oError)

1. Creation of an instance of type Error as a result of an exception.
2. Creating a new (second) instance of type Error: XSharp.Error{pErrInfo}
3. Creation of a new (third) instance of type Error: ErrorBuild(...)
   In this case, step 2 is not needed at all, since the ErrorBuild function already creates an instance of type Error from type Exception. And if we take into account that pErrInfo can already be an instance of the Error type, then it can be immediately passed to cbError:Eval(oError)

I suggest the following modification:

FUNCTION ErrorExec(pErrInfo AS Exception) AS USUAL
    local cbError as CODEBLOCK
    local oError  as XSharp.Error
    cbError := ErrorBlock()
    IF ( pErrInfo IS Error )
        oError := (Error)pErrInfo
    ELSE
	oError := ErrorBuild(pErrInfo)
    ENDIF
    RETURN cbError:Eval(oError)

P.S. I also ask you to change the name of the 'pErrInfo' variable to something more like the type of the variable (Exception). For example, 'err' or 'info' or something else. Since the 'p' prefix no longer makes sense and can be confusing.