Fix equipment disconnect UI: proper success message and complete UI clearing #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server returns {"equipment_id": "...", "status": "disconnected"}
but the UI was checking for a "success" field, causing disconnect to
show as failed even though it worked.
Changes:
- Check for status == "disconnected" instead of success field
- Clear selected_equipment, readings_display, and info_display on disconnect
- Prevents stale readings/info from remaining after disconnect
Fixes disconnect showing "failed" message despite actually working.
Fixed AttributeError where code tried to clear 'info_display' which doesn't exist. Equipment info is displayed via individual labels (name_label, type_label, etc.) not a single QTextEdit widget. Now properly clears all equipment detail labels on disconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes equipment disconnect showing error despite working, and ensures all UI elements are properly cleared after disconnect.
Issues Fixed
1. Disconnect Shows "Failed" Despite Working
Problem:
When clicking disconnect button:
Root Cause:
Server returns:
{"equipment_id": "ps_56fdd3df", "status": "disconnected"}